s9e Media Sites 2.15.6

[Chromaniac]

Just wanted to ping you if you can check if Add a title to the click-to-load placeholders where available option is working on 2.3. Thanks!

Update: Based on logs, it definitely has been working on 2.3 betas. So, I am guessing it is just a temporary glitch from YouTube's end which does happen regularly.

 

[JoshyPHP]

The logic for fetching those titles is a bit fuzzy. If there are already 2 pending fetches, it won't try to add more, and even if there are no pending fetches it won't execute more than 1 for the current page. That's why even on an empty forum with no users, some titles may be missing, even if temporarily. I gave it very conservative values because fetching a video's title synchronously while the page is being generated can delay it by a lot more than you save using a lightweight placeholder.

 

[Chromaniac]

yeah i remember how you implemented it. the thing is that the entirety of the xf_oembed table has null in the title column. it's likely youtube is restricting my ip or something because it definitely was fetching titles properly on beta builds of 2.3. have disabled this feature right now and would try again after a few days. thanks!

 

[JoshyPHP]

XenForo adds a NULL entry when it attempts (or schedules? can't remember) a new oEmbed fetch. If the cron thing that updates oEmbeds runs a bit behind, it's possible that you'll find some of those. I think they remain null when XenForo gives up after a number of failed attempts. That could somewhat explain those entries, although I'm kinda guessing here.

 

[CZ Eddie]

We're running Xenforo 2.0 and won't be able to upgrade for another year (nobody available to do the work).

I temporarily disabled s9e to see if X.com would start working.
When I went to re-enable s9e, it's giving me an error saying that it requires PHP 7.4.
I am not trying to upgrade. I'm just trying to turn it back on. It was working fine when I clicked the disable button as a test.
Any suggestions?

Edit:
Nevermind, I downgraded from 2.8.3 to 2.7.18 and was able to enable again.

 

[Chromaniac]

just wanted to post this as a fyi. the dark mode for embeds like twitter does not seem to work on firefox at my end on dark theme on 2.3. no one has complained so far though. i guess the user base on firefox is just negligible or maybe it's just broken at my end. thanks!

 

[JoshyPHP]

What's the name of the theme? If it's a free one I'll take a look at it on my local board.

 

[Chromaniac]

the dark variant on 2.3! default xenforo theme. the update you shipped few days ago. it works fine on chrome. but was using firefox today for something and noticed twitter embeds were white. example post

also just noticed that this might be happening in chrome as well if system option is selected. which explains why it was white on firefox. i was using a test account and theme was likely set at system.

 

[JoshyPHP]

Oh, right. If you're on the system setting, the theme is set/switched in JavaScript so it's impossible to know in PHP whether it's going to end up light or dark at the time the embed's HTML is generated. I will consider adding some form of detection for the more dynamic embeds such as Twitter's. It will be limited to 2.3 (since it relies on the style variation being set to system) and it won't work for static stuff like Spotify.