XF Optimise

[x4rl]

I'm trying to add adbrite to my website and it's forcing the adds to the bottom with the javascript mover enabled Any chance I can stop this?

Not untill he adds them into the whitelist same as twitter

 

[Junior]

Not untill he adds them into the whitelist same as twitter

Ah whitelist

/library/Dark/XFOptimise/Iroha.php

Changed this line:

return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false;

To this:

return stripos($match, "google_ad") !== false ||stripos($match, "AdBrite") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false;

 

[Luke F]

A configurable whitelist is coming soon

 

[a legacy reborn]

I'm trying to add adbrite to my website and it's forcing the adds to the bottom with the javascript mover enabled Any chance I can stop this?

Well...after posting this I have realized there was another page...sigh

 

[Ryan Kent]

I installed this add-on today. I made sure my js and js-old folders were 777 then ran it in the ACP. I received a message stating "An unexpected database error occurred. Please try again later."

I checked my js-old directory and it had all the correct folders present. I ran it again and a page header of Minify Javascript appeared, listing all my files with a message of "skipped; already up to date".

I assume all is well?

Also, I am experiencing the same issue smsmasters reported. On my home page I have a twitter module. The block remains in place but all of the tweets appear below the footer instead of within the block. I have a similar issue on my forums where I have a ventrilo monitoring block.

I disabled Defer Javascript Loading in the ACP and the issue went away. How can I adjust so I can turn that option back on?

 

[Junior]

I'm sending you a pm Oracle.

 

[x4rl]

I installed this add-on today. I made sure my js and js-old folders were 777 then ran it in the ACP. I received a message stating "An unexpected database error occurred. Please try again later."

I checked my js-old directory and it had all the correct folders present. I ran it again and a page header of Minify Javascript appeared, listing all my files with a message of "skipped; already up to date".

I assume all is well?

Also, I am experiencing the same issue smsmasters reported. On my home page I have a twitter module. The block remains in place but all of the tweets appear below the footer instead of within the block. I have a similar issue on my forums where I have a ventrilo monitoring block.

I disabled Defer Javascript Loading in the ACP and the issue went away. How can I adjust so I can turn that option back on?

Not untill he adds them into the whitelist same as twitter

Or you can make the changes yourself.

 

[Ryan Kent]

I would like to understand how to determine the correct code used to fix the issue I am experiencing with my modules.

For example, my Twitter module issue that smsmasters and I shared where all the code appears at the bottom of the site. I understand I need to ad it to the below code. Instead of "google_ad" or "AdBrite" what do I use? I MUST understand how that tag is determined. I have multiple other non-standard js dependent blocks on my site. One for MS Translator, another for a ventrilo monitor, etc.

stripos($match, "google_ad") !== false;

 

[Luke F]

I would like to understand how to determine the correct code used to fix the issue I am experiencing with my modules.

For example, my Twitter module issue that smsmasters and I shared where all the code appears at the bottom of the site. I understand I need to ad it to the below code. Instead of "google_ad" or "AdBrite" what do I use? I MUST understand how that tag is determined. I have multiple other non-standard js dependent blocks on my site. One for MS Translator, another for a ventrilo monitor, etc.

stripos($match, "google_ad") !== false;

Any unique text from the url or inline script code

 

[Ryan Kent]

So for my twitter block the js line is:
http://widgets.twimg.com/j/2/widget.js

I believe twimg would be the most unique term, but that is used in multiple places so would the below work? I am asking because I found one specific line http://widgets.twimg.com/i/widget-logo.png used on the same page.

stripos($match, "widgets.twimg.com/j") !== false;

 

[Ryan Kent]

Whenever I make any change to the Iroha.php file and save it, my site immediately gives the below error on all pages

Parse error: syntax error, unexpected T_BOOLEAN_OR in /home/terapvpc/public_html/library/Dark/XFOptimise/Iroha.php on line 48

Unaltered code

protected function _jsLeave($match){ return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false; }

Code with my adjustment

 protected function _jsLeave($match){ return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false; || stripos($match, "widgets.twitter.com/j") !== false; }

Code with the adjustment Junior suggested:

 protected function _jsLeave($match){ return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false; || stripos($match, "TWTR") !== false; || stripos($match, "twimg") !== false; }

 

[Luke F]

There should only be one semicolon (at the end)

 

[Ryan Kent]

TY DI. I removed the ; from my script and my site didn't crash

I tried my adjustment listed above, and it did not work. The tweets were still taken from the sidebar and placed at the bottom of the screen. I then tried the code Junior suggested and it worked.

My main question now is...how were the "TWTR" and "twimg" terms decided upon? and how come that block requires two entries?

The reason I ask is I have a couple other javascripts on my site. I cannot use the Defer JS Loading option until they are all adjusted for. For example my ventilo script is

<div class="section">
   <div class="secondaryContent statsList" id="vent">
      <h3>Ventrilo</h3>
      <span id="instantventrilo"><a href="http://www.instantventrilo.com/">ventrilo</a> Hosting by InstantVentrilo.com</span><script type="text/javascript" src="http://view.light-speed.com/ventrilo.php?IP=v44.darkstarllc.com&amp;PORT=27504&amp;STYLE=2&amp;CHANNEL_WNOUSER=NO&amp;SHOW_IP_PORT=YES&amp;HELP=YES&amp;CONLINK=YES&amp;WIDTH=225&amp;FONTSIZE=10&amp;BGCOLOR=393939&amp;SN_BGCOLOR=393939&amp;SN_COLOR=969696&amp;INFO_BGCOLOR=393939&amp;INFO_COLOR=ffffff&amp;HELP_BGCOLOR=393939&amp;HELP_COLOR=000000&amp;CHANNEL_BGCOLOR=c8c8c8&amp;CHANNEL_COLOR=969696&amp;UN_BG=393939&amp;UN=1061b3&amp;METHOD=js"></script>
</div>
</div>

 

[x4rl]

~~

Ive also been trying to block twitter and was unable to ..
You will just have to wait untill dark adds it to the next release same as me I guess

 

[Ryan Kent]

Ive also been trying to block twitter and was unable to ..
You will just have to wait untill dark adds it to the next release same as me I guess

Junior's code works perfectly. Replace your line of code with the below and your Xen Portal twitter block will appear correctly.

protected function _jsLeave($match){ return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false; || stripos($match, "TWTR") !== false; || stripos($match, "twimg") !== false; }

 

[x4rl]

Junior's code works perfectly. Replace your line of code with the below and your Xen Portal twitter block will appear correctly.

protected function _jsLeave($match){ return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false; || stripos($match, "TWTR") !== false; || stripos($match, "twimg") !== false; }

Hmm no it don't also as dark says there is too many semicolon in that code

should be

protected function _jsLeave($match){
return stripos($match, "google_ad") !== false || stripos($match, "show_ad") !== false || stripos($match, "_google") !== false || stripos($match, "TWTR") !== false || stripos($match, "twimg") !== false;
}

But that still does not work

 

[Ryan Kent]

I do apologize about forgetting to remove the semicolons in the code I shared with you, but I am not mistaken about the code working.

It is working on my site right now. Take a look:

Home page: www.TeraPVP.com notice my twitter box appears fine
Forum page www.TeraPVP.com/forum notice in the sidebar my ventrilo block is empty, then scroll down and you will see the contents at the bottom

I'll leave my site in this state for a bit so you can confirm, but I will remove the vent block in about 20 minutes.

 

[x4rl]

I do apologize about forgetting to remove the semicolons in the code I shared with you, but I am not mistaken about the code working.

Np's

Odd don't work for me
http://animelon.com/
http://animelon.com/members/vodkaholic.1/

 

[Ryan Kent]

I see your twitter block but not the contents. For me the contents appeared at the bottom of the page. Where did yours go?

PS. I really love your site. It looks so clean.

 

[x4rl]

I see your twitter block but not the contents. For me the contents appeared at the bottom of the page. Where did yours go?

Same as you at the bottom (this is with it on) with that code replace.. Just don't show

PS. I really love your site. It looks so clean.

Thanks