XF 2.3 Why doesn't XF call enqueuePostUpgradeCleanUp automatically?

[Sim]

Referring to the new automatic file cleanup feature in XF 2.3, the announcement says the following:

Developers who wish to trigger an automatic clean up of their own files, can do so by calling the following from within their add-on Setup class in the postUpgrade method:​

​

$this->enqueuePostUpgradeCleanUp();

​

My question is - under what circumstances would you not want to run this?

Is there a reason why I shouldn't just add this to every Setup.php file for my addons?

If so, why doesn't XF simply call this automatically whenever an addon is upgraded?

 

[Chris D]

That is included in the official add-ons and the clean up automatically happens (in different ways) depending on how XF upgrades are conducted.

You probably should include it in your add-ons, yes, if appropriate