if a,b,c

[Robert9]

I can do

if a=
elseif b =
elseif c=

means that a= will break and save running time

What happens when I do

if a= or b= or c=
will php stop working here also if a= is true?

 

[Robert9]

Can I short this?

        if (
            (preg_match('#\[opener\](.*)\[/opener\]#is', $message, $matches))
            || (preg_match('#\[excerpt\](.*)\[/excerpt\]#is', $message, $matches))
            || (preg_match('#\[snippet\](.*)\[/snippet\]#is', $message, $matches))
        )

 

[mazzly]

I can do

if a=
elseif b =
elseif c=

means that a= will break and save running time

What happens when I do

if a= or b= or c=
will php stop working here also if a= is true?

Yes, it will stop evaluating the rest of the if-statement as soon as it has a match.

 

[Robert9]

So it is the same in the same row, a, then b, than c, right?

 

[Kirby]

Short-circuit evaluation - Wikipedia

en.m.wikipedia.org

 if (preg_match('#\[(opener|excerpt|snippet)\](.*)\[/\1\]#is', $message, $matches))

 

[Robert9]

Works with $matches[2], tahnk you.
the next step would be not so easy, i guess:

Any idea how to sub_str my snippet without cutting bbcodes?

b, i, u could maybe be cut and get a new [/end
but we can't cut attach]

 

[whynot]

Can I short this?

        if (
            (preg_match('#\[opener\](.*)\[/opener\]#is', $message, $matches))
            || (preg_match('#\[excerpt\](.*)\[/excerpt\]#is', $message, $matches))
            || (preg_match('#\[snippet\](.*)\[/snippet\]#is', $message, $matches))
        )

Take care:

(preg_match('#\[opener\](.*)\[/opener\]#is', $message, $matches));
|| (preg_match('#\[excerpt\](.*)\[/excerpt\]#is', $message, $matches));
|| (preg_match('#\[snippet\](.*)\[/snippet\]#is', $message, $matches));

 

[Robert9]

Thank you, code is changed like

   public function setPreview(&$error = null)
    {
        $message = $this->message;
        $options = \XF::options();

        if (
            preg_match('#\[(opener|excerpt|)\](.*)\[/\1\]#is', $message, $matches)
        )
        {
            $this->message = trim($matches[2]);
        }
        elseif (preg_match('#\[snippet\](.*)\[/snippet\]#is', $message, $matches))
        {
            $this->message = trim(substr($matches[1], 0, $options->xcTopics1SnippetLength)) . " ...";
        }
        else
        {
            if ($options->XCTopics1TopicsUseSnippetAlways)
            {
                $this->message = trim(substr($message, 0, $options->xcTopics1SnippetLength)) . " ...";
            }
        }
    }

 

[whynot]

if ( preg_match('#\[(opener|excerpt|)\](.*)\[/\1\]#is', $message, $matches) ) { .......

I believe it should be:
if (preg_match('#\[(opener|excerpt|)\](.*)\[/\1\]#is', $message, $matches) {