Add-on Install & Upgrade 1.4.3

[Chris D]

Nothing substantial has changed for a long time, so any recent update must be completely unrelated, e.g. if it worked before, it should still work now. What version did you update from, recently?

Do CloudFlare provide any logs as to why the site went offline? Certainly any web server logs will be essential to work out what's actually happening.

 

[rdn]

Since updating to the latest version, installing/updating any addon results in the forum going offline (Cloudflare). I then have to click "Retry for live version", and click the manual rebuild option.
Any ideas? This does not happen when uploading files and importing xml.

Disallow Cloudflare on your admin.php page via page rules *admin.php*

 

[Chris D]

@Liam W can you give me access to one of your add-ons that behaves wrong. I tried with one and it seemed to work fine, though this may also be an OS behaviour hence why I can't reproduce it, but I will be testing it cross platform to be sure.

Scratch that, I can reproduce it.

Seems fixed with the updated code.

It seems in the new version I've got, I had already modified the code. Not exactly the same as rellect's suggestion, but to the same ends.

Frustratingly, it hasn't solved the issue with VaultWiki so I have to do some more work to figure out why that is.

 

[Chris D]

@pegasus I have fixed the issue with installing VaultWiki in the latest version.

My add-on LOVES to see an upload directory. If it sees an upload directory, as is common with most XF add-ons, it knows the intention is to upload the contents of the upload directory to the root of XenForo.

That's all good until it finds ANOTHER one several directories deeper, e.g.:

vaultwiki_lite_400r4p1b1_xf/upload/vault/core/controller/ui/ajax/upload

Which of course contains vw.php and a blank index.html file

At one point, my code returns an array of directories that it would like to use, keyed by folder name, e.g. "upload". So by the time it's recursed through all of the files, this second upload directory was the only upload directory it was going to use.

In the next version, I have changed the behaviour so that duplicate folder names are ignored, so only the first folder it finds that is allowed is used.

 

[Golden Falcon]

Hi,

Addon works great on most addons. For some reason I tried to install this and it failed: https://xenforo.com/community/resources/history.2653/

Both with Option 1 & 2.

 

[Chris D]

Could you please define how it "failed"? Was there a particular error message?

 

[Golden Falcon]

Could you please define how it "failed"? Was there a particular error message?

I apologize.

This is the error:

Error
The files associated with this add-on could not be found. Please upload them and try again.

 

[Chris D]

Ok, thanks.

I will try it on the new version that is currently in development. I will hopefully get a chance to finish it this weekend.

 

[Eoj Nawoh]

Lately when I try to install utilizing the URL, I'm getting:

Server Error
Given file is no zip archive

1. Zend_Filter_Compress_Zip->decompress() in Zend/Filter/Decompress.php at line 47
2. Zend_Filter_Decompress->filter() in AddOnInstaller/Model/AddOn.php at line 29
3. AddOnInstaller_Model_AddOn->extractZip() in AddOnInstaller/ControllerAdmin/AddOn.php at line 146
4. AddOnInstaller_ControllerAdmin_AddOn->actionInstallUpgrade() in XenForo/FrontController.php at line 347
5. XenForo_FrontController->dispatch() in XenForo/FrontController.php at line 134
6. XenForo_FrontController->run() in /home/triangle/subdomains/staff.thetriangle.org/admin.php at line 13

 

[Chris D]

I'd need to know which URLs to be able too do any sort of debugging on that. Generally, URL downloads are working so I will need something that isn't working for you to test with,

 

[Eoj Nawoh]

I'd need to know which URLs to be able too do any sort of debugging on that. Generally, URL downloads are working so I will need something that isn't working for you to test with,

https://xenforo.com/community/resources/live-update.274/

This was the one that failed. (One of yours coincidentally.)

 

[loplo]

Hey Chris,
Since ~2 weeks lots of waindigo resources are being flagged as upgrade available. I can confirm that all the resources are up to date.

 

[Chris D]

Is the version that is listed next to the add-on in your Admin CP the same version that is listed on the resource in the Resource Manager?

Can you give me a specific example?

 

[loplo]

Yes they're the same.
These are the resources:
Conversation Search by Waindigo
Custom Fields by Waindigo
Extra Node Information by Waindigo
Install and Upgrade by Waindigo
Join User Group by Waindigo
Keyword Replace by Waindigo
Smilie Importer by Waindigo
Thumbnails by Waindigo
User Upgrades by Waindigo

If you want to take a closer look, I can provide a user/pass for the forum.

 

[The Grand Potentate]

Is the version that is listed next to the add-on in your Admin CP the same version that is listed on the resource in the Resource Manager?

Can you give me a specific example?

Same thing I told you about a little while ago. Its flagging all of his addons as needing upgrading.

 

[Alpha1]

It would be nice if the update checker would work for official addons as well.

 

[rdn]

It would be nice if the update checker would work for official addons as well.

I'm sure it will happen
More advanced feature

 

[loplo]

Same thing I told you about a little while ago. Its flagging all of his addons as needing upgrading.

Did you manage to get rid of the issue?

 

[The Grand Potentate]

Did you manage to get rid of the issue?

You just have to force ignore them all, or just ignore it all together. Or switch out Waindigo addons for some other developers.

 

[loplo]

At the moment I'm ignoring them.
Did you have issues with other addons, or only the Waindigo ones were affected?