Fixed [E_DEPRECATED] strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated

[TickTackk]

Affected version

XF 2.3

When running only

php cmd.php xf-dev:generate-finders

 

[Chris D]

Do you have a full stack trace?

 

[TickTackk]

In Manager.php line 129:

  [ErrorException]
  [E_DEPRECATED] strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated


Exception trace:
  at /<path to xf>/src/XF/AddOn/Manager.php:129
 XF::handlePhpError() at n/a:n/a
 strtoupper() at /<path to xf>/src/XF/AddOn/Manager.php:129
 XF\AddOn\Manager->coerceAddOnId() at /<path to xf>/src/XF/AddOn/Manager.php:111
 XF\AddOn\Manager->getById() at /<path to xf>/src/XF/Cli/Command/Development/GenerateFinders.php:37
 XF\Cli\Command\Development\GenerateFinders->execute() at /<path to xf>/src/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at /<path to xf>/src/XF/Cli/Command/Development/RequiresDevModeTrait.php:20
 XF\Cli\Command\Development\GenerateFinders->run() at /<path to xf>/src/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at /<path to xf>/src/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at /<path to xf>/src/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at /<path to xf>/src/XF/Cli/Runner.php:111
 XF\Cli\Runner->run() at /<path to xf>/cmd.php:15

Running PHP 8.3.6.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.0 Beta 6).

Change log:

Ensure an add-on ID is required when generating finders.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Chris D]

An add-on ID is required for this command but it wasn't enforced correctly.