[DigitalPoint] App for Cloudflare®

[DigitalPoint] App for Cloudflare® 1.8.4.1

No permission to download
They are also getting rid of Auto Minify in August 🤷‍♂️.

To gain anything out of minification (html, javascript, css, etc.) it must be done on your own server prior to reaching Cloudflare. Minification by itself has never been a great performance improvement, but if done on your own server, could have a slight performance gain.

Cloudflare has advanced a lot recently and now offers full encryption and compression (gzip & brotli) end-to-end. Any type of minification that takes place on Cloudflare servers now will cause worse performance for your site. This is why "Auto Minify" is already deprecated and going to be removed soon.

Any server interested in site performance compresses data prior to sending it. In order for Cloudflare to minify your content, Cloudflare must first decompress the data, then minify it, and then recompress it. In this process any slight performance gained from the minification process is totally lost to the performance hit taken by decompressing and recompressing the data.
 
XF 2.3 update?

 
XF 2.3 update?

There was an update for 2.3 here, but no one said one way or another if it worked for them or not, so I never rolled it out officially:

 
Still not exactly clear why XenForo 2.3 wants to keep part of the data directory local instead of in the filesystem you want to use, but will figure that out (and possibly address if needed) later.
Any clarity on this yet? Response from XF etc.?
 
Any clarity on this yet? Response from XF etc.?
Has to do with CORS, so it makes sense to keep things simple and not require sites to setup CORS policies to make a vanilla install work.

See:
 
Has to do with CORS, so it makes sense to keep things simple and not require sites to setup CORS policies to make a vanilla install work.
Thanks. As I posted in that thread, I'm hoping that sometime soon XF has no local files requirement, to allow for easy server load balancing and costs savings.
 
I am not using the R2 component of the addon but I had to make the file edit mentioned here. Without this, I was getting server error log entries on 2.3 betas. No other issues since then except that Percent cached in cloudflare graph has dropped down quite a bit. From 70%+ to 20% despite most settings remaining the same. I am not sure if this is due to webp conversion or some other change in 2.3. I do notice that some images that are webp are listed as jpegs (content-type) in networking panel on devtools at some places. Profile images mostly which continue to retain jpeg file extension but that should not be causing so much drop in percentage cached lol. Icon is missing in the admin side panel for the addon listing. And some settings do not appear to process like the ones with checkboxes.
 

Attachments

  • 1716969813200.webp
    1716969813200.webp
    25 KB · Views: 9
Getting this on accessing setting after update.

Code:
ErrorException: [E_WARNING] Trying to access array offset on false in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 1088
XF::handlePhpError() in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 1088
DigitalPoint\Cloudflare\Repository\CloudflareAbstract->getZoneSettings() in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 794
DigitalPoint\Cloudflare\Repository\CloudflareAbstract->organizeSettings() in src/addons/DigitalPoint/Cloudflare/Admin/Controller/Cloudflare.php at line 49
DigitalPoint\Cloudflare\Admin\Controller\Cloudflare->actionIndex() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 258
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2607
XF\App->run() in src/XF.php at line 533
XF::runApp() in admin.php at line 13
 
Getting this on accessing setting after update.

Code:
ErrorException: [E_WARNING] Trying to access array offset on false in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 1088
XF::handlePhpError() in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 1088
DigitalPoint\Cloudflare\Repository\CloudflareAbstract->getZoneSettings() in src/addons/DigitalPoint/Cloudflare/Repository/Cloudflare.php at line 794
DigitalPoint\Cloudflare\Repository\CloudflareAbstract->organizeSettings() in src/addons/DigitalPoint/Cloudflare/Admin/Controller/Cloudflare.php at line 49
DigitalPoint\Cloudflare\Admin\Controller\Cloudflare->actionIndex() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 258
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2607
XF\App->run() in src/XF.php at line 533
XF::runApp() in admin.php at line 13
Ya, there seems to be something going on with the Cloudflare API (slowness for some of the calls). It seems to work itself out if you reload the page, but does seem to be something happening on Cloudflare's side right now.
 
right. happens randomly. any plans to add an icon for the sidebar 🙂? i do not even remember how it was on 2.2. but it has been missing on betas. thanks!
 

Attachments

  • 1717003444488.webp
    1717003444488.webp
    3.8 KB · Views: 6
Nothing change with that, and when I tested it, it's working as expected for me. Do you have any errors in your browser console?

I have an error in ACP:


Code:
Registro de errores del servidor
TypeError: Template admin:cloudflare_firewall_country error: XF\Util\Str::strtolower(): Argument #1 ($string) must be of type string, null given, called in /home/lrwgoull/foropositores.com/src/XF/Template/Templater.php on line 4421 src/XF/Util/Str.php:212
Generado por: --- 30 Mayo 2024 a las 17:41
Seguimiento
#0 src/XF/Template/Templater.php(4421): XF\Util\Str::strtolower(NULL)
#1 src/XF/Template/Templater.php(1196): XF\Template\Templater->fnContains(Object(MaZ\AUN\XF\Template\Templater), false, NULL, 'http.request.fu...')
#2 internal_data/code_cache/templates/l2/s0/admin/cloudflare_firewall_country.php(36): XF\Template\Templater->func('contains', Array, false)
#3 src/XF/Template/Templater.php(1760): XF\Template\Templater->{closure}(Object(MaZ\AUN\XF\Template\Templater), Array, NULL)
#4 src/addons/MaZ/AUN/XF/Template/Templater.php(39): XF\Template\Templater->renderTemplate('cloudflare_fire...', Array, true, NULL)
#5 src/XF/Template/Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:cloudflar...', Array)
#6 src/XF/Mvc/Renderer/Json.php(86): XF\Template\Template->render()
#7 src/XF/Mvc/Renderer/Json.php(70): XF\Mvc\Renderer\Json->renderHtmlFallback('DigitalPoint\\Cl...', 'admin:cloudflar...', Array)
#8 src/XF/Mvc/Dispatcher.php(461): XF\Mvc\Renderer\Json->renderView('DigitalPoint\\Cl...', 'admin:cloudflar...', Array)
#9 src/XF/Mvc/Dispatcher.php(443): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#12 src/XF/App.php(2607): XF\Mvc\Dispatcher->run()
#13 src/XF.php(533): XF\App->run()
#14 admin.php(13): XF::runApp('XF\\Admin\\App')
#15 {main}
Estado de la solicitud
array(4) {
  ["url"] => string(179) "/admin.php?cloudflare/firewall/country&_xfRequestUri=%2Fadmin.php%3Fcloudflare%2Ffirewall&_xfWithData=1&_xfToken=1717083702%2Cdc2f767592fcff0fd50c37df693e8f1b&_xfResponseType=json"
  ["referrer"] => string(55) "https://---.com/admin.php?cloudflare/firewall"
  ["_GET"] => array(5) {
    ["cloudflare/firewall/country"] => string(0) ""
    ["_xfRequestUri"] => string(30) "/admin.php?cloudflare/firewall"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(43) "1717083702,dc2f767592fcff0fd50c37df693e8f1b"
    ["_xfResponseType"] => string(4) "json"
  }
  ["_POST"] => array(0) {
  }
}
 
I have an error in ACP:


Code:
Registro de errores del servidor
TypeError: Template admin:cloudflare_firewall_country error: XF\Util\Str::strtolower(): Argument #1 ($string) must be of type string, null given, called in /home/lrwgoull/foropositores.com/src/XF/Template/Templater.php on line 4421 src/XF/Util/Str.php:212
Generado por: --- 30 Mayo 2024 a las 17:41
Seguimiento
#0 src/XF/Template/Templater.php(4421): XF\Util\Str::strtolower(NULL)
#1 src/XF/Template/Templater.php(1196): XF\Template\Templater->fnContains(Object(MaZ\AUN\XF\Template\Templater), false, NULL, 'http.request.fu...')
#2 internal_data/code_cache/templates/l2/s0/admin/cloudflare_firewall_country.php(36): XF\Template\Templater->func('contains', Array, false)
#3 src/XF/Template/Templater.php(1760): XF\Template\Templater->{closure}(Object(MaZ\AUN\XF\Template\Templater), Array, NULL)
#4 src/addons/MaZ/AUN/XF/Template/Templater.php(39): XF\Template\Templater->renderTemplate('cloudflare_fire...', Array, true, NULL)
#5 src/XF/Template/Template.php(24): MaZ\AUN\XF\Template\Templater->renderTemplate('admin:cloudflar...', Array)
#6 src/XF/Mvc/Renderer/Json.php(86): XF\Template\Template->render()
#7 src/XF/Mvc/Renderer/Json.php(70): XF\Mvc\Renderer\Json->renderHtmlFallback('DigitalPoint\\Cl...', 'admin:cloudflar...', Array)
#8 src/XF/Mvc/Dispatcher.php(461): XF\Mvc\Renderer\Json->renderView('DigitalPoint\\Cl...', 'admin:cloudflar...', Array)
#9 src/XF/Mvc/Dispatcher.php(443): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Json), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'json')
#12 src/XF/App.php(2607): XF\Mvc\Dispatcher->run()
#13 src/XF.php(533): XF\App->run()
#14 admin.php(13): XF::runApp('XF\\Admin\\App')
#15 {main}
Estado de la solicitud
array(4) {
  ["url"] => string(179) "/admin.php?cloudflare/firewall/country&_xfRequestUri=%2Fadmin.php%3Fcloudflare%2Ffirewall&_xfWithData=1&_xfToken=1717083702%2Cdc2f767592fcff0fd50c37df693e8f1b&_xfResponseType=json"
  ["referrer"] => string(55) "https://---.com/admin.php?cloudflare/firewall"
  ["_GET"] => array(5) {
    ["cloudflare/firewall/country"] => string(0) ""
    ["_xfRequestUri"] => string(30) "/admin.php?cloudflare/firewall"
    ["_xfWithData"] => string(1) "1"
    ["_xfToken"] => string(43) "1717083702,dc2f767592fcff0fd50c37df693e8f1b"
    ["_xfResponseType"] => string(4) "json"
  }
  ["_POST"] => array(0) {
  }
}
It looks like XenForo introduced a new Util class in the later versions of 2.3 (wasn't there in beta 3 I know) that makes it's own internal strtolower() function incompatible with PHP's. Easy enough to fix, but I'm wondering if it should be made to be compatible with PHP's normal string functions (can see this causing all sorts of other problems).

Looks like it was added in beta 6:

 
Top Bottom