Recent content by Xon

A major problem is how getFinalDecision is used, is a number of hard-coded switch statements use it, which makes implementing say "accept & report" (instead of moderate or deny) very hard to implement.

Except for the spam trigger log admin page, nothing reads from this table (well beyond pruning code). So removing the unique constraint and making logSpamTrigger append without overwriting and using getFinalDecision should be backwards compatible.

The XF\Spam\AbstractChecker::logSpamTrigger computes a single discussion which doesn't match how XF\Spam\AbstractChecker::getFinalDecision implements it. This can result in the spam log entry having the wrong spam trigger action. ie moderated vs denied. Additionally logSpamTrigger skips...

I haven't updated this addon for XF2.3 yet.

I think this is largely an end-user issue or a Samsung Internet Browser being kicked into a non-standard mode. So this can be marked as not-a-bug

That isn't supported.. It would be doable with additional queries. but I haven't found someone to fund that work as a priority so it is on the backburner while I work on other client work and XF2.3 updates

I really need samples of the html you are copy & pasting, and the raw bb-code that is causing editor issues. Screenshots just don't carry enough information to reliably reproduce all editor issues To get the raw bb-code/html; Edit the post in question, switch to bb-code mode, and then refresh...

I haven't had a chance to update this add-on for XF2.3 yet.

The problem is the edit code path is this: $editor = $this->setupBookmarkEditor($bookmark); $editor->save(); $this->finalizeBookmarkEditor($editor); Instead of: $editor = $this->setupBookmarkEditor($bookmark); if (!$editor->validate($errors)) { throw...

LogicException: Cannot save with validation errors. Use validate() to ensure there are no errors. (First error: Please enter a value using 280 characters or fewer.) src/XF/Service/ValidateAndSavableTrait.php:36 Stack trace #0 src/XF/ControllerPlugin/Bookmark.php(188)...

XenForo implements temporary attachments without additional constraints to view them, with the guest posting feature this sadly can be trivially exploited for spam: The only real solution is to lock viewing temporary attachments to the session which created them for guests, or for the...

Especially useful if there was a way to use existing rest API and to force it to consider a transaction to be considered payment for a user upgrade. I haven't explored the rest api, but can it access subscriptions created the old way? If so this would allow finding the latest transaction for...

While the REST api is a way forward, I think it needs a "force check paypal state" functionality for pending payments to catch the case where the webhook has failed and can't be resent would be ideal

A few sites I admin for recently experienced an issue where IPN just didn't get send. After opening a support ticket with paypal, I eventually received this: (Formatting from paypal)

This has effectively been implemented in several places in XF. I think part of the issue is while the entity structure record has a with argument, there isn't any consistent structure to how it is used/implemented for this sort of use-case (ie for view/for list/etc).